| View previous topic :: View next topic |
| Author |
Message |
hmmpic
Joined: 09 Mar 2010
Posts: 314
Location: Denmark
|
| Just updated from 5020 to 5023. |
 Posted: Sun Mar 30, 2014 8:40 am |
 |
|
Hi
Just updated from 5020 to 5023.
I always make a *.lst compare after an update, and some tests.
I found this, in the old 5020 the GIE was disabled before the table read, and now it is not. Is that ok. If an int came in in the middle can it make problem?
5020:
| Code: | ................... #device PIC18F26K22
000AE: MOVFF INTCON,0D
000B2: BCF INTCON.GIEH
000B4: CLRF TBLPTRH
000B6: ADDLW C8
000B8: MOVWF TBLPTRL
000BA: MOVLW 00
000BC: ADDWFC TBLPTRH,F
000BE: TBLRD*+
000C0: MOVF TABLAT,W
000C2: BTFSC 0D.7
000C4: BSF INTCON.GIEH
000C6: RETURN 0
|
5023:
| Code: | .................... #device PIC18F26K22
000AE: CLRF TBLPTRH
000B0: ADDLW BE
000B2: MOVWF TBLPTRL
000B4: MOVLW 00
000B6: ADDWFC TBLPTRH,F
000B8: TBLRD*+
000BA: MOVF TABLAT,W
000BC: RETURN 0 |
Advise? |
|
 |
Ttelmah
Joined: 11 Mar 2010
Posts: 19538
|
|
| Posted: Sun Mar 30, 2014 9:22 am |
|
|
It's a good thing....
It was the core cause of an earlier complaint, where the GIE bit remained accidentally cleared. Since the table pointers are saved when interrupts are called, it was pointless... |
|
|
hmmpic
Joined: 09 Mar 2010
Posts: 314
Location: Denmark
|
|
| Posted: Sun Mar 30, 2014 10:06 am |
|
|
| Understood, thanks. |
|
|
|
FAQ 
Search
Register
Profile 
Log in to check your private messages 
Log in
