(NOT) Saving data from Bluetooth to array

[ressas]

18F46k22

Hello.
I am trying to save the data coming via Bluetooth into an array. However, I later realized that there was a problem reading the values from the array. Tell me like this:

[temtronic]

Quick comments
For starters....
See EOL comments...
1st all variables should be bytes NOT words. Data from UART will be 8 bits.

2nd 'array' has zero space allocated. Pretty sure YOU need to specify an amount, say 32 bytes for test purposes.

3rd this...

#INT_RDA
void serialInterrupt()
{
clear_interrupt(INT_RDA); //// delete this line, compiler does this
value=getc();

array[k] = value;
k++;

delay_ms(20); //// delete this line, NEVER have delays in ISRs

enable_interrupts(INT_RDA); //// delete this line, compiler does this
enable_interrupts(GLOBAL); //// delete this line, compiler does this
}

edit/recompile/test/see what happens

[Ttelmah]

Actually, I'd just 'disagree' with this comment:

enable_interrupts(GLOBAL); //// delete this line, compiler does this

The compiler does not do this. The _CHIP_ does this. The global
interrupt bit is disabled by the chip hardware as soon as an interrupt
handler is entered. The return from interrupt instruction automatically
re enables this bit when the interrupt exits.
It is absolutely vital on the PIC, that the global interrupt is never enabled
inside an interrupt handler. Doing so can/will result in the interrupt being
called again inside itself. Since the PIC's own hardware register saving
only supports one lot of values, if this happens, you are in a disaster.

You must never use enable_interrupts(GLOBAL) inside an interrupt handler.

Only a 'pedant mode' comment, but it is a critically important thing
about PIC interrupt handling....

[ressas]

Thank you for your answer.
Actually, I knew my problem would not be solved since I did not share all of my code. I am not sharing it here because it is too long. But I have to share.
Before reviewing the code, please watch this short video and understand what the code will do.

[url] https://www.youtube.com/watch?v=iviJ6-IiJ10 [/url]
Actually the reason I define variables as 16 is because I don't want to drive the RGB display.

So the variables I guess the variables should remain 16 bits. Any other suggestions?

RGB.h

[Ttelmah]

First fix the ISR issues, and then give some space to the array you want to
store the values in,

You need something like:

[ressas]

[temtronic]

Ok I think I understand what it is.... the PIC has direct control over 8 'power' pins and 24 ( 3 x 8 ) 'colour' pins ( RGB) that are connected to the LED display module.
A PC sends a 'data stream' with the pixel # and color information, the PIC then turns on/off the required pin of the RGB 8x8 display.

First, you do not need 16bit variables, so change to 8 bits ( bytes). The port output functions are byte width. Code using bytes is faster than words (16 bits), and speed is important with direct drive LEDs.

looking at the code as I type...
you have main() include a file called RGB_martix.h BUT have shown RGB.h !
This file is the pin assignments . Since the program compiles, the 'matrix' file must exist but perhaps it's wrong ?

also you need 'errors' added to the use RS232(...options..)

if you can post the make/model LED display, that could be helpful. I might be able to find a translated version of code, well Google might !!

[ressas]

Thanks Temtronic. Actually, I already have a working code. You can review that code below. Since I don't want it to be too long, I try to shorten the following code with various algorithms. And yes I shortened it. The code above works fine. It only shows the current value on the matrix. It does not show previous values. So I want to apply what I did in the code below to it. Saving data in an array. If I can do that. The above code will work perfectly.

[Ttelmah]

One comment though.
This:

clear_interrupt(INT_RDA);

is completely pointless....

You _cannot_ clear INT_RDA, until the character is read from the UART.
So all this does is waste an instruction. The compiler itself automatically
clears interrupts when the ISR is exited (unless you specify 'NOCLEAR'),
so it is just a waste....

[ressas]

Thank you Ttelmah
I care about your comments. These small fixes get me closer to writing professional code. Please tell me if there is any other error. Otherwise I'll keep making small mistakes forever :(