glcd 128x64 menu problem

[exodia505]

hello guys !
i'm trying to build a project which is about measurement station , in this project i use a 128x64 glcd (ks0108) . i display menu +sub-mesnu and plot graph.
this project works well on proteus ,and doesn't work well on real hardware .
i use a keypad (4 buttons (up+down+ok+return) to navigate between menus )
the problem is i dont press anything and see changes, random display of menu .

///////////////////////////////////////////////////////////////////////////////////////////////////////////////////
//////////////////////////////////////////////////////////////////////////////////////////////////////////////////
this is a second part of code (menu controle )



glcd_init(on); /
glcd_showimage(&image_9);
while(1){

eta1:
if(input(pin_b1)==1) / RB1 : button "up"
{
delay_ms(30);
l=l+1; /inc of variable L { from 0 to 3 } i have 4 images .
if(l>3) l=0;
}
if(input(pin_b2)==1) /RB2: Button "down"
{
delay_ms(30);
l=l-1;
if(l>3) l=3;

}
switch(l)
{
case 0:glcd_showimage(&image_0); / l=0 then show first image .

if(input(pin_b3)==1) / RB3 : Button ok .
{
s=1;
while(s=1) / button ok pressed then send data via rs232
{
glcd_fillscreen(0);

glcd_text57(20,10,rs232,1,on);

printf("%f \n\r",current);
printf("%f \n\r",press);
printf("%f \n\r",volt);
printf("%f \n\r",temp);

if(input(pin_b4)==1) { // RB4: Button "return" if its pressed bck to show first image
s=0;
goto eta1;}
}
}
break;
case 1:glcd_showimage(&image_1); //l=1 then show second image
if(input(pin_b3)==1) //if ok button pressed
{
glcd_fillscreen(0);
framevolts(5,0,125,51); //framevolts use to show a frame for plotting
n=1;

while(n=1)
{
eta2: if(input(pin_b1)==1) // up button pressed
{
delay_ms(10);
m=m+1;
if(m>4) m=0; / i do same to first menu
}
if(input(pin_b2)==1)
{
delay_ms(10);
m=m-1;
if(m>4) m=4; //
}
if(input(pin_b4)==1)
{
goto eta1;
}
switch(m)
{

case 0: glcd_showimage(&image_5);
if(input(pin_b3)==1)
{
glcd_fillscreen(0);
framevolts(5,0,125,51);
glcd_text57(48,57,tmp1,1,on);
s2=1;
while(s2=1)
{
if(input(pin_b4)==1)
{
goto eta2;
}
draw((int)current*5); //plot variable current .
delay_ms(20);


}
}
break;
case 1:
glcd_showimage(&image_6);
if(input(pin_b3)==1)
{
glcd_fillscreen(0);
framevolts(5,0,125,51);
glcd_text57(48,57,tmp,1,on);
s2=1;
while(s2=1)
{
if(input(pin_b4)==1)
{
goto eta2;
}
draw((int)volt*20);
delay_ms(10);


}
}

break;
case 2:
glcd_showimage(&image_7);
if(input(pin_b3)==1)
{
glcd_fillscreen(0);
framevolts(5,0,125,51);
glcd_text57(48,57,tmp3,1,on);
s2=1;
while(s2=1)
{
if(input(pin_b4)==1)
{
goto eta2;
}
draw((int)press);
delay_ms(10);


}
}
break;
case 3:
glcd_showimage(&image_8);
if(input(pin_b3)==1)
{
glcd_fillscreen(0);
framevolts(5,0,125,51);
glcd_text57(48,57,tmp2,1,on);
s2=1;
while(s2=1)
{
if(input(pin_b4)==1)
{
goto eta2;
}
draw((int)temp);
delay_ms(5);


}
}

break;
case 4: glcd_showimage(&image_10);
if(input(pin_b3)==1)
{
glcd_fillscreen(0);
framevolts(5,0,125,51);
glcd_text57(48,57,tmp1,1,on);
s2=1;
while(s2=1)
{
if(input(pin_b4)==1)
{
goto eta2;
}
draw((int)current*5);
delay_ms(20);


}
}
break;
}
}
}
break;
case 2:glcd_showimage(&image_2);
if(input(pin_b3)==1)
{

}
break;
case 3:glcd_showimage(&image_3);
if(input(pin_b3)==1)
{
glcd_fillscreen(0);
glcd_rect(1,1,125,50,off,on);
delay_ms(20);
glcd_rect(10,10,110,40,off,on);
delay_ms(20);
glcd_text57(3,20,contact,1,on);
delay_ms(20);
glcd_text57(15,52,web,1,on);
delay_ms(800);
}
break;
}
}
}

here is a video that shows my problem (sorry i didn't find any way to upload it just on youtube ! sorry )
http://www.youtube.com/watch?v=jlT1woWM68M&feature=youtu.be
advices to improve the code
thanks !!!
_________________
NOway!!

[Mike Walne]

You've just learnt your first valuable lesson. Forget proteus, it's so full of bugs.

Lesson 2

Read the CCS forum guidelines.

Use the code box to show your code. As it stands it's almost impossible to decipher.

Have you got pull up resistors on your key inputs or are you relying on the port B internals?

Reduce your code to the minimum which demonstrates your problem.

I sounds like you MAY have button problems.

Try just reading the buttons and sending the button states to LEDs on other pins.

Give your buttons names which correspond with their functions, this will make your code more readable.

When you get stuck, post a complete compilable code which we can test.

Mike

[ezflyr]

Hi,

I could be wrong, but it looks like a switch bounce problem to me. I've had excellent luck with the 'Button' function written by forum user PCM programmer. This function is used to read and debounce switches. It's easy to implement, and it seems to work great. In fact, I use it in a menu system for a clock that uses a 128x64 GLCD.

Button Function: http://www.ccsinfo.com/forum/viewtopic.php?t=23837

John

[Mike Walne]

The display's responding without pressing any buttons.

So either :-

Spurious output from the buttons, possibly caused by bad connection, faulty buttons, electrostatic pick-up if they're floating.......

OR

Some other part of the software is sending data to the LCD.

At this stage it's a divide and conquer excercise.

Mike

[ezflyr]

Hi Mike,

I guess I missed the part where he said "I don't press anything and see changes", and must have seen a phantom hand in the video pressing buttons

He may have his buttons wired incorrectly, or his logic messed up! Here is a line from his code:

[Mike Walne]

Hi John,

We need the answers to lots of questions.

Could be using pull down resistors, open circuit, we can't tell.

Coding seems to be working on high for button pressed, which could be the problem.

We're wasting time and effort trying to second guess.

Mike

[exodia505]

HI, Mike !
what are the questions that you want their answers?
_________________
NOway!!

[temtronic]

First off, a fully documented schematic would be a good start......

Second, you could 'fudge' the keypad entries and see if the rest of the program functions the way it should..that would eliminate most of the potential issues with the keypad. Simply recode (add a function) to accept data from a PC terminal program instead of the keypad. Call this 'data-from-pc' function instead of the 'keypad' function.

Third, follow up with the results....

The more you tell us the better (and faster) the replies will be.

[ezflyr]

[Mike Walne]

Like I said before it's a divide and conquer exercise.

Without you touching the buttons, your display behaves as though you were.

So, split the problem into two sections; buttons & display.

Test each separately from the other.

Find out which works correctly, and which does not.


TESTING THE BUTTONS

I've already suggested replacing the GLCD with four LEDs.

Each LED corresponding to one button.

As you press each of your four buttons, its LED should light.


TESTING THE GLCD.

Temtronic has suggested replacing the buttons with an RS232 input from a PC.

As you press each key on your PC the GLCD should respond as intended.



You've given us no indication of your schematic.

Ezflyr has asked specifically for details of your button wiring.


Can we assume that each of your four buttons is connected like this?